Support explicit view hints; support synchronous Gauge configuration #185
Conversation
|
|
||
| var hint view.Hint | ||
| if err := json.Unmarshal([]byte(instrument.Description), &hint); err != nil { | ||
| // This could be noisy if valid descriptions contain spurious '{' chars. |
There was a problem hiding this comment.
Is there a way we could make the hinting more explicit to avoid potential noise here?
There was a problem hiding this comment.
An explicit hint could be accomplished with the OTel API if the API changes--this is a standing feature request. For the way we have planned, there won't be noise because the source has no metric descriptions, and if it did it knows how to wrap them in JSON syntax to do the right thing.
To avoid this side-channeling, we could use a separate data structure, possibly with a more-explicit back-channel into the viewstate code to achieve the override. I would document this as experimental support aimed at helping understand the need for hints in the OTel API; users would be advised to be careful and plan on switching to a hints API in the future.
There was a problem hiding this comment.
i see, maybe for now this is fine then. I think explicit hinting via the otel API is the right way to go, and after this is merged and in use, we'll have a use case to show for it.
Description:
Allows metric instruments with JSON body in their description to achieve a programmatic view configuration.
This enables three things for Lightstep's internal use:
Link to tracking Issue:
LS-30446: additional configuration needed to adapt Lightstep-internal metrics libraries
Documentation: Comments in code; requires README before this merges to the main branch.