removed andOTP recomendation from translation source and fixed incorrect link on translations that don't mention andOTP. #13969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Google authenticator Android link
ComradeRamen
changed the title
|
I didn't remove andOTP link from scala because I assume it breaks translations that haven't removed andOTP yet. |
Correct link for authenticator
|
Fixed translations that linked to andOTP instead of Android Google authenticator but didn't mention andOTP. Still a number of translations that include andOTP (with the correct link) which I didn't touch |
ComradeRamen
changed the title
|
|
ornicar
reviewed
Nov 19, 2023
| @@ -2,7 +2,7 @@ | |||
| <resources> | |||
| <string name="twoFactorAuth">Two-factor authentication</string> | |||
| <string name="twoFactorHelp">Two-factor authentication adds another layer of security to your account.</string> | |||
| <string name="twoFactorApp">Get an app for two-factor authentication, for example andOTP for %1$s or Google Authenticator for %2$s.</string> | |||
| <string name="twoFactorApp">Get an app for two-factor authentication, for example Google Authenticator for %3$s or %2$s.</string> | |||
There was a problem hiding this comment.
translations variables should start at %1$s
ornicar
added a commit
that referenced
this pull request
Nov 19, 2023
* master: replace 2FA Android app - closes #13968 - closes #13969 always show tournament verdict reason use Tournament.isEnterable remove superfluous account CSS classes, some scala tweaks dont flow text around official blog teaser image show completed game result in blind mode fix typo prettierignore readme and add -n short arg for --no-install remove unnecessary tsc flag fix insight & chart tsc deps fixing Removes conditional formatting Swiss requirements Cleaned up tournament.isStarted check css fixed #13867 tournament requirements styling add tag id and link
ornicar
added a commit
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
andOTP is archived #13968
English translation doesn't mention andOTP but links to the andOTP android app.