Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change styling of entry requirements when viewing finished tournaments #13867

Closed
fitztrev opened this issue Oct 29, 2023 · 2 comments · Fixed by #14019
Closed

Change styling of entry requirements when viewing finished tournaments #13867

fitztrev opened this issue Oct 29, 2023 · 2 comments · Fixed by #14019
Labels
good first issue Narrow in scope (but not necessarily easy) improvement Small incremental improvement to an existing feature

Comments

@fitztrev
Copy link
Member

fitztrev commented Oct 29, 2023 •
edited
Loading

If you play in a ≤2000 arena and then go above 2000 after it is completed, the entry requirement will show as unsatisfied even though the tournament is over.

image

We can hide that section on finished tournaments.
Remove green/red colors and checkmark/x for finished tournaments.
@fitztrev fitztrev added improvement Small incremental improvement to an existing feature good first issue Narrow in scope (but not necessarily easy) labels Oct 29, 2023
brokenVectors added a commit to brokenVectors/lila that referenced this issue Oct 29, 2023
@brokenVectors
Fixed issue lichess-org#13867
8857eee
@brokenVectors
Copy link
Contributor

I've submitted a pull request to fix this issue, however I haven't been able to test it thoroughly: see the PR for more information.

@ornicar
Copy link
Collaborator

ornicar commented Oct 30, 2023

The requirements should still be visible, as they're a defining trait of the tournament. What can be removed are the colours and the ✔️ and X icons.

@ornicar ornicar mentioned this issue Oct 30, 2023
Closed
@fitztrev fitztrev changed the title Hide entry requirements when viewing finished tournaments Change styling of entry requirements when viewing finished tournaments Oct 30, 2023
@niklasf niklasf linked a pull request Oct 30, 2023 that will close this issue
tweak entry requirement display of completed tournaments #13872
Closed
@DJoepie DJoepie mentioned this issue Nov 16, 2023
Merged
ornicar added a commit that referenced this issue Nov 19, 2023
@ornicar
Merge pull request #14019 from DJoepie/fix-issue-13867
9b2e90a 
fixed #13867 tournament requirements styling
ornicar added a commit that referenced this issue Nov 19, 2023
@ornicar
Merge branch 'master' into flair
8a98364 
* master:
  replace 2FA Android app - closes #13968 - closes #13969
  always show tournament verdict reason
  use Tournament.isEnterable
  remove superfluous account CSS classes, some scala tweaks
  dont flow text around official blog teaser image
  show completed game result in blind mode
  fix typo
  prettierignore readme and add -n short arg for --no-install
  remove unnecessary tsc flag
  fix insight & chart tsc deps
  fixing
  Removes conditional formatting Swiss requirements
  Cleaned up tournament.isStarted check
  css
  fixed #13867 tournament requirements styling
  add tag id and link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Narrow in scope (but not necessarily easy) improvement Small incremental improvement to an existing feature
Projects
Lichess Good First Issues
Archived in project
Milestone
No milestone
3 participants
@ornicar @fitztrev @brokenVectors