Desktop: Fixes #10466: Fix tables missing source map attributes #10516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tableHorizontallyScrollable overrides table_open and table_close, without calling the default rule handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #10466 by causing tableHorizontallyScrollable.ts to use an existing renderer rule internally for
table_openandtable_close, if it exists, when rendering a table.Previously, the
table_openrenderer rule assigned by thetable_openrule was ignored.Testing plan
This pull request includes an automated test. It has also been tested manually by creating a note with a table and verifying that the table has
source-lineandsource-line-endattributes.