Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute source-line and source-line-end missing for tables #10466

Closed
JackGruber opened this issue May 24, 2024 · 0 comments · Fixed by #10516
Closed

Attribute source-line and source-line-end missing for tables #10466

JackGruber opened this issue May 24, 2024 · 0 comments · Fixed by #10516
Assignees
@personalizedrefrigerator
Labels
bug It's a bug desktop All desktop platforms high High priority issues renderer About the note renderer

Comments

@JackGruber
Copy link
Contributor

JackGruber commented May 24, 2024 •
edited
Loading

Operating system

Windows

Joplin version

3.0.8

Desktop version info

Joplin 3.0.8 (dev, win32)

Client ID: 84acc903d582412193f7b29e05fb7093
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: 826006c

Current behaviour

In the Renderd markdown, tables in the Joplin version before 3.0.3 have a attribute source-line and source-line-end, this attribute is missing in the Joplin 3.0.3 versions for tables.

This means, for example, that plugin Markdown Table: Sortable no longer works

The Bug was possible introduced with: Improved: Make tables horizontally scrollable #10161

Joplin 3.0.8
grafik

Joplin 2.14.22
grafik

Example Table

|a|b|
|---|---|
|1|2|

sdf
sdf
sd
f
sdfsdfsdf

Expected behaviour

The attribute source-line and source-line-end should be added again to the table.

Logs

No response
@JackGruber JackGruber added the bug It's a bug label May 24, 2024
@JackGruber JackGruber mentioned this issue May 24, 2024
Closed
@personalizedrefrigerator personalizedrefrigerator added high High priority issues renderer About the note renderer desktop All desktop platforms labels May 24, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue May 28, 2024
@personalizedrefrigerator
Desktop: Fixes laurent22#10466: Fix tables missing source map attributes
e7e210d 
tableHorizontallyScrollable overrides table_open and table_close,
without calling the default rule handlers.
Merged
laurent22 pushed a commit that referenced this issue May 30, 2024
@personalizedrefrigerator
Desktop: Fixes #10466: Fix tables missing source map attributes (#10516)
418a6e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@personalizedrefrigerator personalizedrefrigerator

Labels
bug It's a bug desktop All desktop platforms high High priority issues renderer About the note renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Desktop: Fixes #10466: Fix tables missing source map attributes personalizedrefrigerator/joplin
2 participants
@JackGruber @personalizedrefrigerator