Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop running apt-get process in script, setup supervisor #25

Closed
wants to merge 32 commits into from
Closed

stop running apt-get process in script, setup supervisor #25

wants to merge 32 commits into from

Conversation

gegere
Copy link

@gegere gegere commented Jan 7, 2015

Kyle, this merge will not happen automatically. Basically this build creates a more stable and faster starting container. I would be happy to go over some of this with you and help merge with it while also cleaning up documentation. I also set you a message on G+.

@kylemanna
Copy link
Owner

Sorry, but this pull request is an absolute mess.

You need to do a few things:

  1. Break up to the pull request in to individual small atomic features
  2. Squash and clean-up the commits so that other people can read them and make sense of them "fix stupid mistake" and "oops" are not valid commit message
  3. Explain why the pull request should be merged (i.e. what was done, how it was done and why it was done).

I'd recommend reviewing with the Linux Kernel Submitting Patches doc as a large portion of the open source community uses this as a guide (not bible) for how to frame patch sets.

@kylemanna kylemanna closed this Jan 7, 2015
@kylemanna
Copy link
Owner

Also:

  1. It needs to cleanly apply to the master branch of the repo.

@gegere
Copy link
Author

gegere commented Jan 7, 2015

I have already read all this and understand it. Sorry I'll pull it back. Cheers!

@gegere gegere deleted the master branch January 7, 2015 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants