Use --cap-add=NET_ADMIN instead of --privileged #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the patch, I like the reduced privileges. My concern is that --cap-add was added in Docker 1.2 and many distros I like the reduced privileges, but want to avoid confusion for older Could you update your patch to include both invocations and a very brief explanation? |
Ovpn doesn't need all the capabilities. https://docs.docker.com/reference/run/#runtime-privilege-linux-capabilities-and-lxc-configuration says: For interacting with the network stack, instead of using --privileged they should use --cap-add=NET_ADMIN to modify the network interfaces.
|
Done |
kylemanna
added a commit
that referenced
this pull request
Oct 7, 2014
Use --cap-add=NET_ADMIN instead of --privileged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ovpn doesn't need all the capabilities.
https://docs.docker.com/reference/run/#runtime-privilege-linux-capabilities-and-lxc-configuration says: