Fixing the helm chart integration tests.

[phillipsj]

No description provided.

[phillipsj]

/assign

[jsturtevant]

Should we be creating a new package instead of overwriting the existing 0.4.0? I don't know what is considered best practice here for releasing templates

[phillipsj]

@marosset @jsturtevant I addressed all of your feedback. Thanks for the reviews.

[jsturtevant]

Looks like we now have two folders for charts. I've done some research and it looks like don't need to version the folder that the chart lives in itself which is why we are having a bit of trouble here. Looking at https://v2.helm.sh/docs/developing_charts/#store-charts-in-your-chart-repository (I found this example as well: https://github.com/kubernetes-sigs/cloud-provider-azure/tree/master/helm)

We can have a directory structure like:

- `charts/gmsa` this can have the template files, chart files, vaules.yaml, etc
- `charts/repo` this contains the  index.yaml and tgz files once we want to version them.  

The workflow would be make updates to the charts/gmsa. The PR's wouldn't generate any tgz pacakges. Once we were ready to release and version the chart would could generate the tgz pacakge, move it to the charts/repo and update the index to use the correct version.

The tests themselves would reference the charts/gmsa folder and not use the tgz files. Later we could add a periodic job or maybe modify the integration test to generate a temporary tgz package to deploy to verify that works as well.

Does that make sense?

[jsturtevant]

we could fix the test here, then open a separate PR to move these files around to the correct location which might make more sense.

[jsturtevant]

lgtm, Thanks for cleaning all this up. Do we need to update the readme install instructions with the correct url to add the repository?

Test is using the helm chart 🚀

installing helm deployment windows-gmsa-dev with chart /home/runner/work/windows-gmsa/windows-gmsa/charts/gmsa and image :
KUBECONFIG=/home/runner/work/windows-gmsa/windows-gmsa/admission-webhook/dev/kubeconfig-windows-gmsa-chart-integration /usr/local/bin/kubectl create namespace windows-gmsa-dev
namespace/windows-gmsa-dev created
KUBECONFIG=/home/runner/work/windows-gmsa/windows-gmsa/admission-webhook/dev/kubeconfig-windows-gmsa-chart-integration /usr/local/bin/helm version
version.BuildInfo{Version:"v3.9.0", GitCommit:"7ceeda6c585217a19a1131663d8cd1f7d641b2a7", GitTreeState:"clean", GoVersion:"go1.17.5"}
KUBECONFIG=/home/runner/work/windows-gmsa/windows-gmsa/admission-webhook/dev/kubeconfig-windows-gmsa-chart-integration /usr/local/bin/helm install windows-gmsa-dev /home/runner/work/windows-gmsa/windows-gmsa/charts/gmsa --namespace windows-gmsa-dev
NAME: windows-gmsa-dev
LAST DEPLOYED: Wed May 25 16:13:50 2022
NAMESPACE: windows-gmsa-dev
STATUS: deployed
REVISION: 1
TEST SUITE: None
KUBECONFIG=/home/runner/work/windows-gmsa/windows-gmsa/admission-webhook/dev/kubeconfig-windows-gmsa-chart-integration /usr/local/bin/kubectl wait -n windows-gmsa-dev pod -l app=windows-gmsa-dev --for=condition=Ready
pod/windows-gmsa-dev-6c6b5ddffb-njff4 condition met
make[1]: Leaving directory '/home/runner/work/windows-gmsa/windows-gmsa/admission-webhook'
### Starting integration tests with Kubernetes version: 1.23.4 ###

[jsturtevant]

/lgtm

[marosset]

Do we need to update https://github.com/kubernetes-sigs/windows-gmsa/blob/master/RELEASE.md?

[phillipsj]

@marosset I would say not yet, I think we need to automate the generation and update of the index.

[marosset]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, phillipsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment