kuring-168 메인 화면을 compose로 migrate #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwy3055
commented
Jun 18, 2024
feature/main/src/main/java/com/ku_stacks/ku_ring/main/MainScreen.kt
Outdated
Show resolved
Hide resolved
l2hyunwoo
approved these changes
Jun 19, 2024
Comment on lines
117
to
119
| override fun <V : AnimationVector> vectorize(typeConverter: TwoWayConverter<Float, V>): VectorizedDecayAnimationSpec<V> { | ||
| TODO("Not yet implemented by mwy3055") | ||
| } |
There was a problem hiding this comment.
이번에 Navigation 버전을 업그레이드할 때 androidx.compose.foundation:foundation-android가 함께 업글되면서 추가된 매개변수인데, 용례를 거의 찾아보기 힘든 클래스라 일단 TODO로 놔뒀습니다. (이후 PR에서 구현할 예정이었음)
하루 정도 검색해본 결과, 사용 예시가 거의 없는 반면 스위치 애니메이션에 미치는 영향은 미미하다고 판단하여 da662ae 에서 가장 basic한 형태로만 구현했습니다.
| } | ||
| } | ||
| composable<MainScreenRoute.Settings> { | ||
| // TODO by mwy3055: SettingScreen 내부도 navigation으로 migrate해야 함 |
There was a problem hiding this comment.
여긴 아직 마이그레이션이 안되어있군요ㅋㅋㅋ 나중에 진행하시죠
There was a problem hiding this comment.
Activity와 기존 string 기반 내비게이션이 섞여 있습니다. 전부 compose + type-safe로 통일하는 게 목표.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kuring.atlassian.net/browse/KURING-168?atlOrigin=eyJpIjoiNWY0MTI0YmMzYjZmNGFlZWI3MGZkNDE5ZjI5YWEyODAiLCJwIjoiaiJ9
작업 내용
메인 화면에 compose type-safe navigation을 적용하였습니다.
Route 선언 및 navigation graph 생성 모두 기본적인 API만으로 작업하였습니다. 더 좋은 방법론이 있다면 적극 리뷰 부탁드립니다.
MainActivity에서 XML 대신MainScreencomposable을 사용이후 작업
메인 탭 4개의 navigation 선언SettingScreen도 type-safe navigation으로 전환 (현재는 String 기반)