Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Type-safe navigation route용 KuringRoute를 인터페이스로 분리 #268

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

mwy3055
Copy link
Member

@mwy3055 mwy3055 commented Jul 13, 2024

https://kuring.atlassian.net/browse/KURING-168?atlOrigin=eyJpIjoiYTkwNjg2MGEwN2RkNDkyYWIzMjA4YjEzNjhjNzg4MzciLCJwIjoiaiJ9

요약

메인 화면 navigation migration 작업을 재개하였습니다. 구체적으로 말씀드리면, 설정 탭을 compose + type-safe navigation으로 migrate하는 중입니다.

작업에 앞서 현우님이 #235 에서 정의하셨던 route 코드를 인터페이스로 분리했습니다. 나중에 다른 화면에서도 사용할 수 있을 것 같아 :common:ui_util 모듈에 정의했습니다.

커밋 설명

  • c8b6674: KuringRoute 인터페이스 분리

Copy link
Contributor

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mwy3055 mwy3055 merged commit f7524fd into develop Jul 13, 2024
2 checks passed
@mwy3055 mwy3055 deleted the feature/kuring-168_kuring_route branch July 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants