Fix part of oppia#3775: RTL Exempted file fixes (oppia#3776)

* Change barrierDirection in topic_practice_subtopic files. * Change barrierDirection in topic_practice_subtopic files. * Change barrierDirection in topic_practice_subtopic files. * Add back add_profile_activity. * Remove empty space. Co-authored-by: viktoriia <[email protected]>
kritigupta45 · Sep 16, 2021 · 000dfd9 · 000dfd9
1 parent 908d57b
commit 000dfd9
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 11 deletions.
diff --git a/app/src/main/res/layout-land/topic_practice_subtopic.xml b/app/src/main/res/layout-land/topic_practice_subtopic.xml
@@ -18,7 +18,7 @@
  android:layout_height="wrap_content"
  android:layout_marginStart="104dp"
  android:layout_marginEnd="96dp"
- app:barrierDirection="right">
+ app:barrierDirection="end">
 
  <androidx.constraintlayout.widget.Barrier
  android:id="@+id/topic_practice_subtopic_barrier"

diff --git a/app/src/main/res/layout-sw600dp-land/topic_practice_subtopic.xml b/app/src/main/res/layout-sw600dp-land/topic_practice_subtopic.xml
@@ -22,7 +22,7 @@
  android:layout_height="wrap_content"
  android:layout_gravity="center"
  android:layout_marginStart="8dp"
- app:barrierDirection="right">
+ app:barrierDirection="end">
 
  <androidx.constraintlayout.widget.Barrier
  android:id="@+id/topic_practice_subtopic_barrier"

diff --git a/app/src/main/res/layout-sw600dp-port/topic_practice_subtopic.xml b/app/src/main/res/layout-sw600dp-port/topic_practice_subtopic.xml
@@ -22,7 +22,7 @@
  android:layout_height="wrap_content"
  android:layout_gravity="center"
  android:layout_marginStart="8dp"
- app:barrierDirection="right">
+ app:barrierDirection="end">
 
  <androidx.constraintlayout.widget.Barrier
  android:id="@+id/topic_practice_subtopic_barrier"

diff --git a/app/src/main/res/layout/topic_practice_subtopic.xml b/app/src/main/res/layout/topic_practice_subtopic.xml
@@ -18,7 +18,7 @@
  android:layout_height="wrap_content"
  android:layout_marginStart="40dp"
  android:layout_marginEnd="48dp"
- app:barrierDirection="right"
+ app:barrierDirection="end"
  app:constraint_referenced_ids="button_example,text_view_status">
 
  <androidx.constraintlayout.widget.Barrier

diff --git a/scripts/assets/file_content_validation_checks.textproto b/scripts/assets/file_content_validation_checks.textproto
@@ -43,11 +43,8 @@ file_content_checks {
  failure_message: "Use start/end versions of layout properties, instead, for proper RTL support"
  exempted_file_name: "app/src/main/res/layout/add_profile_activity.xml"
  exempted_file_name: "app/src/main/res/layout/profile_progress_header.xml"
- exempted_file_name: "app/src/main/res/layout-land/add_profile_activity.xml"
  exempted_file_name: "app/src/main/res/layout-land/profile_progress_header.xml"
- exempted_file_name: "app/src/main/res/layout-sw600dp-land/add_profile_activity.xml"
  exempted_file_name: "app/src/main/res/layout-sw600dp-land/profile_progress_header.xml"
- exempted_file_name: "app/src/main/res/layout-sw600dp-port/add_profile_activity.xml"
  exempted_file_name: "app/src/main/res/layout-sw600dp-port/profile_progress_header.xml"
  exempted_file_name: "app/src/main/res/values/styles.xml"
 }
@@ -60,10 +57,6 @@ file_content_checks {
  file_path_regex: ".+?.xml"
  prohibited_content_regex: "app:barrierDirection=\"right\""
  failure_message: "Use app:barrierDirection=\"end\", instead, for proper RTL support"
- exempted_file_name: "app/src/main/res/layout/topic_practice_subtopic.xml"
- exempted_file_name: "app/src/main/res/layout-land/topic_practice_subtopic.xml"
- exempted_file_name: "app/src/main/res/layout-sw600dp-land/topic_practice_subtopic.xml"
- exempted_file_name: "app/src/main/res/layout-sw600dp-port/topic_practice_subtopic.xml"
 }
 file_content_checks {
  file_path_regex: ".+?.xml"