forked from assimp/assimp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump contrib/utf8cpp from 60c490b
to 2ad9957
#269
Open
dependabot
wants to merge
43
commits into
master
Choose a base branch
from
dependabot/submodules/contrib/utf8cpp-2ad9957
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: "A static Class Member" in https://abseil.io/tips/140
BaseImporter::SearchFileHeaderForToken() expected a pointer to a non-const token list. This was probably an oversight, as nobody would realistically expect the function to change the list. Furthermore, it prevented token lists from being compiled to read-only memory, in some cases even causing the compiler to generate thread-safe initialization. The list is now const and all callers declare their token lists static const, thus compiling them to read-only memory.
Assimp wasn't compiling on GNU/Linux
including <exception>
Use Safe Constants Idioms for ObjFileParser::DEFAULT_MATERIAL.
* Return 0.0f for empty buffer * closes assimp#3442
Fix possible nullptr dereferencing in material parsing
Update ObjTools.h
more const in format detection
Fix Q1 MDL group frame loading, e.g. Q1 progs/flame2.mdl
- get compiant to tinyobjloader and other importers - closes assimp#3726
Add support for normal maps, the classic way
Fix aiString length not updated in the EmbedTextures postprocess task
This hurts, but we have no control over warnings in our dependencies. For example, the latest zip library compares integer constants and there is nothing we can do about it.
Initially fixed at commit 18b147311d3a3fef348c8bb0e710d0e5ade2b158 from 2011 because this seems to be Assimp’s current version.
Initially fixed at commit d3d87d6af75b7b1d9a9c83af57cb1b35f21aa0e3 from 2021-05-10 because this seems to be Assimp’s current version.
Initially fixed at version 1.4.1 from 2020 because this seems to be Assimp’s current version.
This commit moves contrib/gtest to contrib/googletest/googletest. The googletest repository is divided into googlemock and googletest, but only the latter was included with Assimp. git submodules requires pulling the entire repo, so the path had to be adjusted.
Initially fixed at version 1.11.4 from 2020 because this seems to be Assimp’s current version. CMake required adding the PUGIXML_HEADER_ONLY preprocessor definition, which previously was hard-coded into the header.
Bumps [contrib/utf8cpp](https://github.com/nemtrif/utfcpp) from `60c490b` to `2ad9957`. - [Release notes](https://github.com/nemtrif/utfcpp/releases) - [Commits](nemtrif/utfcpp@60c490b...2ad9957) --- updated-dependencies: - dependency-name: contrib/utf8cpp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
Pull requests that update a dependency file
label
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps contrib/utf8cpp from
60c490b
to2ad9957
.Commits
2ad9957
typos79835a5
Remove -Wsign-conversion from test builds.53398ca
Restructure tests.e3e57c8
Fix for issue #92: Clang 10 Compiler warningsd736c29
Fix -Wconversion warnings in tests when -funsigned-char option is used.780bd57
Merge pull request #96 from Finkman/provide-ns-on-installed73b347f
Adds the following advantages:3ca904b
Version 3.2.2aa3b12c
Added a couple of statis_casts to eliminate signed conversion warnings.ee90a4a
Added compiler options to enable warnings.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)