Fix aiString length not updated in the EmbedTextures postprocess task #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aiStringlength was not updated when the texture path was replaced with the embedded path (i.e.*0) after performing the EmbedTextures postprocess task.This created all sort of problems when performing string manipulation using the
aiString::lengthfield instead of interpretingaiString::dataas c-string (think of applications using UTF8 strings).I also wrote a small unit test for this change, but decided against pushing it because I don't know in which file to put it.
Let me know if I should add it to the pr.