Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Add more test cases #45

Merged
merged 16 commits into from
Jan 29, 2022
Merged

[Test] Add more test cases #45

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
984b807
update: test_load_optimizers_invalid
kozistr Jan 29, 2022
055a5fc
refactor: AdaBound
kozistr Jan 29, 2022
ea2fc51
update: check_valid_parameters
kozistr Jan 29, 2022
97e8e39
update: test_learning_rate
kozistr Jan 29, 2022
970fb87
update: check_valid_parameters
kozistr Jan 29, 2022
0a140b2
update: check_valid_parameters
kozistr Jan 29, 2022
02bd844
update: test_pc_grad_optimizers
kozistr Jan 29, 2022
e1f6e2d
update: test_epsilon
kozistr Jan 29, 2022
09148a7
update: PCGrad
kozistr Jan 29, 2022
11cb973
update: test_weight_decay
kozistr Jan 29, 2022
88b4370
refactor: PCGrad
kozistr Jan 29, 2022
7d707b8
update: test_pc_grad_optimizers
kozistr Jan 29, 2022
f327405
update: split tests
kozistr Jan 29, 2022
6fb3a4f
update: RAdam
kozistr Jan 29, 2022
01dc147
update: test_betas
kozistr Jan 29, 2022
033a842
fix: typo
kozistr Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update: test_betas
  • Loading branch information
@kozistr
kozistr committed Jan 29, 2022
commit 01dc14744a06f7dea6c1842d05956f219f40a5db
32 changes: 28 additions & 4 deletions tests/test_optimizer_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from pytorch_optimizer import load_optimizers

VALID_OPTIMIZER_NAMES: List[str] = [
OPTIMIZER_NAMES: List[str] = [
'adamp',
'sgdp',
'madgrad',
Expand All @@ -19,23 +19,47 @@
'lamb',
]

BETA_OPTIMIZER_NAMES: List[str] = [
'adabelief',
'adabound',
'adahessian',
'admap',
'diffgrad',
'diffrgrad',
'lamb',
'radam',
'ranger',
'ranger21',
]


@pytest.mark.parametrize('optimizer_names', VALID_OPTIMIZER_NAMES)
@pytest.mark.parametrize('optimizer_names', OPTIMIZER_NAMES)
def test_learning_rate(optimizer_names):
with pytest.raises(ValueError):
optimizer = load_optimizers(optimizer_names)
optimizer(None, lr=-1e-2)


@pytest.mark.parametrize('optimizer_names', VALID_OPTIMIZER_NAMES)
@pytest.mark.parametrize('optimizer_names', OPTIMIZER_NAMES)
def test_epsilon(optimizer_names):
with pytest.raises(ValueError):
optimizer = load_optimizers(optimizer_names)
optimizer(None, eps=-1e-6)


@pytest.mark.parametrize('optimizer_names', VALID_OPTIMIZER_NAMES)
@pytest.mark.parametrize('optimizer_names', OPTIMIZER_NAMES)
def test_weight_decay(optimizer_names):
with pytest.raises(ValueError):
optimizer = load_optimizers(optimizer_names)
optimizer(None, weight_decay=-1e-3)


@pytest.mark.parametrize('optimizer_names', BETA_OPTIMIZER_NAMES)
def test_betas(optimizer_names):
with pytest.raises(ValueError):
optimizer = load_optimizers(optimizer_names)
optimizer(None, betas=(-0.1, 0.1))

with pytest.raises(ValueError):
optimizer = load_optimizers(optimizer_names)
optimizer(None, betas=(0.1, -0.1))