Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add more test cases #45

Merged
merged 16 commits into from
Jan 29, 2022
Merged

[Test] Add more test cases #45

merged 16 commits into from
Jan 29, 2022

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Jan 29, 2022

Change Log

  • test case for PCGrad
  • test cases for the parameters
    • learning_rate
    • weight_decay
    • eps
    • betas

@kozistr kozistr self-assigned this Jan 29, 2022
@kozistr kozistr added the feature New features label Jan 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #45 (033a842) into main (5f1ef59) will increase coverage by 7.99%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   71.03%   79.02%   +7.99%     
==========================================
  Files          24       24              
  Lines        1602     1626      +24     
==========================================
+ Hits         1138     1285     +147     
+ Misses        464      341     -123     
Impacted Files Coverage Δ
pytorch_optimizer/radam.py 87.64% <ø> (+5.61%) ⬆️
pytorch_optimizer/pcgrad.py 96.20% <91.66%> (+69.95%) ⬆️
pytorch_optimizer/adabelief.py 73.17% <100.00%> (+2.90%) ⬆️
pytorch_optimizer/adabound.py 81.25% <100.00%> (+12.89%) ⬆️
pytorch_optimizer/ranger21.py 92.00% <100.00%> (+0.58%) ⬆️
pytorch_optimizer/madgrad.py 71.91% <0.00%> (+3.37%) ⬆️
pytorch_optimizer/sgdp.py 95.71% <0.00%> (+4.28%) ⬆️
pytorch_optimizer/diffrgrad.py 92.47% <0.00%> (+5.37%) ⬆️
pytorch_optimizer/adamp.py 93.33% <0.00%> (+5.55%) ⬆️
pytorch_optimizer/ranger.py 94.44% <0.00%> (+5.55%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1ef59...033a842. Read the comment docs.

@kozistr kozistr merged commit dc3c356 into main Jan 29, 2022
@kozistr kozistr deleted the test/cases branch January 29, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants