Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocha version and unit tests #117

Merged
merged 3 commits into from
Jan 24, 2018

Conversation

kevinrambaud
Copy link
Contributor

As mentioned in comment #114 (comment), builds are failing due to --no-exit default flag since mocha 4.0.0

To fix this issue, I did the following changes :

  • removed supertest duplicate dependency
  • fixed mocha version
  • updated all test files to empty event loop after running test (the koa app instance were still running)

Copy link
Member

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@kevinrambaud
Copy link
Contributor Author

kevinrambaud commented Jan 24, 2018

Do I need to do any action to make it mergeable by you guys ?

@dead-horse dead-horse merged commit fc7f25a into koajs:master Jan 24, 2018
@dead-horse
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants