Use eslint-config-koa

[nickserv]

https://github.com/koajs/eslint-config-koa

[nickserv]

The linting task passes for me, the build failure is some sort of stall that was also happening on master.

[kevinrambaud]

hey @nickmccurdy the build fails because of the version of mocha. I noticed that its dependecy is set to * to it fetches the last release > 4.0.0.
Mocha 4.0.0 introduced a breaking change that impacts project that runs tests that keep active process in the event loop. (https://mochajs.org/#--exit----no-exit)

You can either fix the mocha dependency in the package.json and add the --exit arguments in the Makefile

test:
	@NODE_ENV=test ./node_modules/.bin/mocha \
		--harmony \
		--reporter spec \
		--require should \
		--exit \
		*/test.js

Or so go through all the existing tests and make sure that the app started is closed after each test file. It can be done as below :

var app = require('./app');
var server = app.listen();
var request = require('supertest').agent(server);

describe('Virtual Host', function() {
  // make sure to close the server after all tests to clear the event loop
  after(function() {
    server.close();
  });
  
  describe('www subdomain koa app', function() {
    describe('when GET /', function() {
      it('should say "Hello from www app"', function(done) {
        request
          .get('/')
          .set('Host', 'www.example.com')
          .expect(200)
          .expect('Hello from www app', done);
      });
// all the others tests below...
};

[kevinrambaud]

I submitted a PR #117 to fix this issue.