Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate 'additionalPrinterColumns' in domain-mapping resource #14592

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented Nov 3, 2023

Fixes #

Proposed Changes

  • remove duplicate 'additionalPrinterColumns' in domain-mapping resource, was seeing
error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 153: mapping key "additionalPrinterColumns" already defined at line 31

Release Note

NONE

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e473c4a) 86.00% compared to head (074a16d) 86.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14592      +/-   ##
==========================================
+ Coverage   86.00%   86.01%   +0.01%     
==========================================
  Files         197      197              
  Lines       14916    14916              
==========================================
+ Hits        12828    12830       +2     
+ Misses       1778     1775       -3     
- Partials      310      311       +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

dprotaso commented Nov 4, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2023
Copy link

knative-prow bot commented Nov 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, k4leung4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2023
@knative-prow knative-prow bot merged commit ec8cf65 into knative:main Nov 4, 2023
75 checks passed
@k4leung4 k4leung4 deleted the dupe branch November 4, 2023 19:38
@dprotaso
Copy link
Member

/cherry-pick release-1.12

@dprotaso
Copy link
Member

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #14653

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #14654

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants