Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additionalPrinterColumns is defined twice in domainmappings.serving.knative.dev CustomResourceDefinition of serving-core.yaml #14652

Closed
jselleck-sans opened this issue Nov 22, 2023 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jselleck-sans
Copy link

jselleck-sans commented Nov 22, 2023

/kind spec

What version of Knative?

1.12.1

Expected Behavior

installing serving-core.yaml as a kustomize base should work.

Actual Behavior

Instead getting the following error:

Error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 153: mapping key "additionalPrinterColumns" already defined at line 31

Steps to Reproduce the Problem

View the 1.12.1 serving-core.yaml file. Line 1694 and line 1816 within the same crd are both additionalPrinterColumns for the same CRD

@jselleck-sans jselleck-sans added the kind/bug Categorizes issue or PR as related to a bug. label Nov 22, 2023
@dprotaso
Copy link
Member

Hmm weird - it was removed before

#14592

@dprotaso
Copy link
Member

I see it was done after we cut v1.12

Is this a big issue for you?

@jselleck-sans
Copy link
Author

I see it was done after we cut v1.12

Is this a big issue for you?

No.. I modified the file locally.

@dprotaso
Copy link
Member

Thanks for letting us know - given this is the second report I'm going to cherry pick this back to our supported releases (v1.12 & v1.11).

#14653

@dprotaso
Copy link
Member

v1.12.2 should automatically come out next Tuesday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants