-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing deprecated serving.knative.dev/release label #12754
Conversation
Signed-off-by: Paul S. Schweigert <[email protected]> Previously agreed these labels would be dropped in release v1.4 See discussion in knative#12215
Codecov Report
@@ Coverage Diff @@
## main #12754 +/- ##
==========================================
- Coverage 87.31% 87.29% -0.03%
==========================================
Files 196 196
Lines 9750 9750
==========================================
- Hits 8513 8511 -2
- Misses 952 953 +1
- Partials 285 286 +1
Continue to review full report at Codecov.
|
I just want to make sure mesh mode installs properly |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel Install worked - test failures are normal - https://testgrid.k8s.io/r/knative-own-testgrid/serving#istio-latest-mesh |
@psschwei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Signed-off-by: Paul S. Schweigert [email protected]
Previously agreed these labels would be dropped in release v1.4
See discussion in #12215
Part of #12215
Release Note