Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated serving.knative.dev/release label #12754

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Mar 18, 2022

Signed-off-by: Paul S. Schweigert [email protected]

Previously agreed these labels would be dropped in release v1.4
See discussion in #12215

Part of #12215

Release Note

`serving.knative.dev/release` labels, deprecated in v1.3, have been removed. Please switch over to using `app.kubernetes.io/name: knative-serving` and `app.kuberentes.io/version: devel`.

Signed-off-by: Paul S. Schweigert <[email protected]>

Previously agreed these labels would be dropped in release v1.4
See discussion in knative#12215
@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/API API objects and controllers size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #12754 (4dff6cd) into main (0753bb1) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12754      +/-   ##
==========================================
- Coverage   87.31%   87.29%   -0.03%     
==========================================
  Files         196      196              
  Lines        9750     9750              
==========================================
- Hits         8513     8511       -2     
- Misses        952      953       +1     
- Partials      285      286       +1     
Impacted Files Coverage Δ
pkg/reconciler/revision/background.go 90.00% <0.00%> (-1.82%) ⬇️
pkg/reconciler/configuration/configuration.go 84.61% <0.00%> (-1.54%) ⬇️
pkg/autoscaler/statforwarder/leases.go 76.97% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0753bb1...4dff6cd. Read the comment docs.

@psschwei psschwei changed the title [WIP] Removing deprecated serving.knative.dev/release label Removing deprecated serving.knative.dev/release label Mar 18, 2022
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2022
@dprotaso
Copy link
Member

I just want to make sure mesh mode installs properly
/test pull-knative-serving-istio-latest-mesh

@dprotaso
Copy link
Member

/lgtm
/approve
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@dprotaso
Copy link
Member

dprotaso commented Mar 21, 2022

/hold cancel

Install worked - test failures are normal - https://testgrid.k8s.io/r/knative-own-testgrid/serving#istio-latest-mesh

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 21, 2022

@psschwei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-serving-istio-latest-mesh 4dff6cd link false /test pull-knative-serving-istio-latest-mesh

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@psschwei
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants