Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version label in query command #5441

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Update version label in query command #5441

merged 1 commit into from
Feb 22, 2023

Conversation

naveenrajm7
Copy link
Contributor

Replace dropped label serving.knative.dev/release with app.kuberentes.io/version in version query command.

"Fixes knative/serving/#13722"

See knative/serving#12754

Proposed Changes

  • Updated version query command for knative serving and eventing

@naveenrajm7
Update version label in query command
292179a 
Replace dropped label 'serving.knative.dev/release' with 'app.kuberentes.io/version'
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 22, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: naveenrajm7 / name: Naveenraj M (292179a)

@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 292179a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/63f579c56601f100086ada77
😎 Deploy Preview https://deploy-preview-5441--knative.netlify.app/docs/install/upgrade/check-install-version
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow
Copy link

knative-prow bot commented Feb 22, 2023

Welcome @naveenrajm7! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
@dprotaso
Copy link
Member

/ok-to-test
/lgtm
/approve

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Feb 22, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, naveenrajm7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@knative-prow knative-prow bot merged commit d7124a4 into knative:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@nak3 nak3 Awaiting requested review from nak3

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update version check documentation
2 participants
@naveenrajm7 @dprotaso