Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation #2

Closed
steima opened this issue Dec 17, 2021 · 7 comments
Closed

German translation #2

steima opened this issue Dec 17, 2021 · 7 comments
Labels
language request Request to add a specific language

Comments

@steima
Copy link

steima commented Dec 17, 2021

@klimeryk if I just translate the .json files in locales is it a problem if then there are some keys missing from the German translation?

@klimeryk
Copy link
Owner

To be clear, this project is still very much WIP. The JSON files are not ready to be translated - there are missing keys, not all strings are there, etc. I just wanted to put the foundation there to make sure it's set up and integrated with the app. But I'm still shaping the UI, so I did not want to invest too much time in carefully making everything translateable when it could change in the next commit.

@klimeryk
Copy link
Owner

I've finally launched the project 🎉 If you're interested in translating it to German, I've added rudimentary instructions here: https://github.com/klimeryk/recalendar.js/blob/master/TRANSLATIONS.md. Of course, happy to answer any questions or clarify stuff.

@klimeryk klimeryk added the language request Request to add a specific language label Dec 31, 2021
steima added a commit to steima/recalendar.js that referenced this issue Jan 7, 2022
steima added a commit to steima/recalendar.js that referenced this issue Jan 11, 2022
@ghost
Copy link

ghost commented Mar 4, 2023

Hello.
Is the project with the German translation still active? I would translate the *json files. Could you then add this to your project?

@frobnia
Copy link

frobnia commented Mar 14, 2023

translated json files attached.

de.zip

@Schneppi
Copy link
Contributor

Schneppi commented Apr 26, 2023

Seems pretty complete. And there's already a Pull request. Will it ever be merged/integrated? 👍

@Schneppi
Copy link
Contributor

Schneppi commented Apr 26, 2023

I've added the files translated by @frobnia in a Pull Request and hope it will be available on https://recalendar.me/ soon :-)

@klimeryk
Copy link
Owner

Thanks, @frobnia and @Schneppi! I've merged the translations in 684e610 (after fixing up the file encoding to make sure all the umlauts show up ;)). Hope it work well for you - please feel free to open new issues and/or pull requests if you see anything that needs adjustments 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language request Request to add a specific language
Projects
None yet
Development

No branches or pull requests

4 participants