Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Back Extra" field to Cloze builtin model #101

Merged
merged 7 commits into from
Jan 4, 2022
Merged

Add "Back Extra" field to Cloze builtin model #101

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3588919
Add CLOZE_MODEL_WITH_EXTRA
kerrickstaley Dec 31, 2021
d74d374
Emit warning when regular CLOZE_MODEL is used
kerrickstaley Jan 1, 2022
ff11f42
Define and use _warn_for_deprecated_builtin_model
kerrickstaley Jan 4, 2022
23c4825
Revert some stuff
kerrickstaley Jan 4, 2022
e1369a9
Fix up tests
kerrickstaley Jan 4, 2022
03b807f
Add information to the README
kerrickstaley Jan 4, 2022
ed94c6e
Add link and don't threaten to take away the feature
kerrickstaley Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Add link and don't threaten to take away the feature
  • Loading branch information
@kerrickstaley
kerrickstaley committed Jan 4, 2022
commit ed94c6eff509dda8b4095fe60f65219c05cf744d
5 changes: 3 additions & 2 deletions genanki/builtin_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,10 @@ def _fix_deprecated_builtin_models_and_warn(model, fields):
if model is CLOZE_MODEL and len(fields) == 1:
fixed_fields = fields + ['']
warnings.warn(
'Using CLOZE_MODEL with a single field is deprecated and may not work in the future.'
'Using CLOZE_MODEL with a single field is deprecated.'
+ ' Please pass two fields, e.g. {} .'.format(repr(fixed_fields))
+ ' See TODO insert link', DeprecationWarning)
+ ' See https://github.com/kerrickstaley/genanki#cloze_model-deprecationwarning .',
DeprecationWarning)
return fixed_fields

return fields