Add "Back Extra" field to Cloze builtin model #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 95.28% 95.41% +0.12%
==========================================
Files 11 11
Lines 318 327 +9
==========================================
+ Hits 303 312 +9
Misses 15 15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a mistake, the "Back Extra" field was omitted from
genanki.builtin_models.CLOZE_MODEL. This field shows extra information on the back of the card.Add this field to
CLOZE_MODEL. Also, add some code that runs inside Note.write_to_db that checks if.fieldshas only one element and.modelisCLOZE_MODEL, and if so, fixes.fieldsand emits a warning.This change may cause minor backwards-incompatibility issues, because the ID of
CLOZE_MODELhas changed. The only visible effect should be that a deck of Cloze notes created before this change and a similar deck created after this change will have different Note Types when both are imported into Anki. (Note Type is the Anki UI's term for what the source code calls Model).