Skip to content

Commit

Permalink
Fix running lint in individual modules (open-telemetry#216)
Browse files Browse the repository at this point in the history
LINT defaults to [lint in
make](https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html)
so it was still running the old go program called `lint`. However this program
isn't included in install-modules anymore. Set LINT in common so all includers
get it.
  • Loading branch information
jrcamp committed May 7, 2020
1 parent 1905d9f commit c63635f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ BUILD_X2=-X $(BUILD_INFO_IMPORT_PATH).Version=$(VERSION)
endif
BUILD_X3=-X github.com/open-telemetry/opentelemetry-collector/internal/version.BuildType=$(BUILD_TYPE)
BUILD_INFO=-ldflags "${BUILD_X1} ${BUILD_X2} ${BUILD_X3}"
LINT=golangci-lint
STATIC_CHECK=staticcheck

.DEFAULT_GOAL := all
Expand Down
1 change: 1 addition & 0 deletions Makefile.Common
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ ADDLICENCESE= addlicense
MISSPELL=misspell -error
MISSPELL_CORRECTION=misspell -w
STATICCHECK=staticcheck
LINT=golangci-lint
IMPI=impi
# BUILD_TYPE should be one of (dev, release).
BUILD_TYPE?=release
Expand Down

0 comments on commit c63635f

Please sign in to comment.