Fix running lint in individual modules #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINT defaults to [lint in make](https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html) so it was still running the old go program called `lint`. However this program isn't included in install-modules anymore. Set LINT in common so all includers get it.
bogdandrutu
approved these changes
May 7, 2020
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
LINT defaults to [lint in make](https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html) so it was still running the old go program called `lint`. However this program isn't included in install-modules anymore. Set LINT in common so all includers get it.
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
- add defaultservicename to config test file Signed-off-by: Hui Kang <[email protected]>
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
* feat: introduce forceFlush Signed-off-by: Dominik Rosiek <[email protected]> * feat: use different instances of splitFunc per reader Signed-off-by: Dominik Rosiek <[email protected]> * feat: introduce multiline struct Signed-off-by: Dominik Rosiek <[email protected]> * feat: force flushing logs after configured period of time * feat: do not force flush if period is set to 0 Signed-off-by: Dominik Rosiek <[email protected]> * Update operator/helper/multiline.go Co-authored-by: Patryk Małek <[email protected]> * fix(multiline): default empty flush period to 0s Signed-off-by: Dominik Rosiek <[email protected]> * docs(multiline): add incode comment for forceFLushPeriod defaults Signed-off-by: Dominik Rosiek <[email protected]> * fix,docs(multiline): update default flushTime After this change there is an issue only with double following force flushes IMO if this occurs, there is issue with regexes configuration, because if two following flushes from application to file doesn't match the regex, something seems to be invalid Signed-off-by: Dominik Rosiek <[email protected]> * fix(file_input): fix and enable TestNoNewline Signed-off-by: Dominik Rosiek <[email protected]> * tests(multiline): add tests for force flush Signed-off-by: Dominik Rosiek <[email protected]> * refactor: move all force flush logic into ForceFlush struct Signed-off-by: Dominik Rosiek <[email protected]> * refactor: exclude forceFlush to be separate entity Signed-off-by: Dominik Rosiek <[email protected]> * refactor(multiline): rename ForceFlusher to Flusher and group with Multiline as Splitter eventually Signed-off-by: Dominik Rosiek <[email protected]> * docs(file_input): add force_flush_period option Signed-off-by: Dominik Rosiek <[email protected]> Co-authored-by: Patryk Małek <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINT defaults to lint in make so it was still running the old go program called
lint. However this program isn't included in install-modules anymore. Set LINT in common so all includers get it.