Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools dependency #3437

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Remove setuptools dependency #3437

merged 4 commits into from
Dec 21, 2023

Conversation

DimedS
Copy link
Contributor

@DimedS DimedS commented Dec 18, 2023

Description

Remove setuptools dependency as mentioned in #2350

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@DimedS DimedS linked an issue Dec 18, 2023 that may be closed by this pull request
@astrojuanlu
Copy link
Member

Failing because of #2350 (comment)

Signed-off-by: Dmitry Sorokin <[email protected]>
@DimedS
Copy link
Contributor Author

DimedS commented Dec 20, 2023

@astrojuanlu I saw your proposals:
#2350 (comment)
but it looks like they both are breaking compatibility changes?

on a first step currently I just emulated setuptools autodiscovery, but maybe it's not a robust solution.
Actually, if a question is just about package name, looks like we can take it from pyproject.toml: from section

[project]
name = 

but maybe it's not a mandatory that it must be pyproject.toml file there, and it will not be a check for quantity of packages also.

@DimedS DimedS marked this pull request as ready for review December 20, 2023 21:48
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally look good! 👍 Just left a minor comment. Also don't forget to update the release notes.

kedro/framework/cli/micropkg.py Outdated Show resolved Hide resolved
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks correct to me 👍🏽

Indeed @DimedS my other proposals were not completely backwards compatible. And relying on pyproject.toml isn't either, because of all the transitions in 0.18 (from 1 pyproject.toml + 1 setup.py, to 2 pyproject.toml, to just 1 pyproject.toml)

Hopefully in the future we'll be able to simplify this logic (or even extract the packages directly from the metadata https://discuss.python.org/t/record-the-top-level-names-of-a-wheel-in-metadata/29494/69?u=astrojuanlu)

@DimedS DimedS requested a review from merelcht December 21, 2023 10:01
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐

@DimedS DimedS merged commit fb09b32 into main Dec 21, 2023
36 checks passed
@DimedS DimedS deleted the 2350-remove-setuptools branch December 21, 2023 10:36
@DimedS DimedS mentioned this pull request Dec 21, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove setuptools from core dependencies
3 participants