-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setuptools from core dependencies #2350
Comments
super reasonable suggestion @ZiruiXuQB - I'm actually amazed this hasn't been suggested before! |
I wouldn't move Alternatively, you could just deprecate the Somewhat relevant (but not a solution): #2280 |
I am adding this to the inbox to make sure we discussed it in backlog grooming. |
Pinging @astrojuanlu |
Now that I've been summoned 👹 let me just note that in the next pip release, if So, I think completing https://github.com/kedro-org/kedro/milestone/36 is becoming more urgent, and after that we could consider this issue. |
Fantastic push astro-👹 |
This is blocked by migrating to |
@astrojuanlu Can we close this already? I think for |
kedro still has a dependency on pip-tools and setuptools: Lines 31 to 36 in 664411d
IIUC, when we remove OTOH, I was under the impression that we needed to wait on #2853 to remove our direct dependency on |
Double check |
This is the code that uses setuptools on runtime: kedro/kedro/framework/cli/micropkg.py Lines 220 to 231 in ae5f6ff
|
Ideas to remove dependency on setuptools:
|
Only removing |
🎉 |
Description
I'm always frustrated when
pip install kedro
upgrades the versions ofsetuptools
,wheel
andpip
.Context
Usually I would not expect
pip install
to upgrade these packages unless I explicitly runpython3 -m pip install --upgrade pip setuptools wheel
.The behaviour is even more surprising as
kedro
does not give a first impression of a package that is related to packaging or dependency management.Possible Implementation
wheel
andpip
dependencies will probably be excluded whenpip-tools
is removed from the core dependencies (by deprecatingkedro build-reqs
)setuptools
can be moved to an optional dependency,kedro[package]
to support the functionality ofkedro package
Possible Alternatives
n/a
The text was updated successfully, but these errors were encountered: