gtk optimizations

soundconverter/gstreamer/converter.py

@@ -237,15 +237,19 @@ def _query_position(self):
  def get_progress(self):
  """Fraction of how much of the task is completed."""
  duration = self.sound_file.duration
- if not self.done:
- position = self._query_position()
- if duration is None:
- return 0
- progress = position / duration
- progress = min(max(progress, 0.0), 1.0)
- return progress, duration
-
- return 1, duration
+
+ # don't waste time querying gstreamer if possible
+ if self.done:
+ return 1, duration
+ if not self.pipeline:
+ return 0, duration
+
+ position = self._query_position()
+ if duration is None:
+ return 0
+ progress = position / duration
+ progress = min(max(progress, 0.0), 1.0)
+ return progress, duration
 
  def cancel(self):
  """Cancel execution of the task."""

soundconverter/interface/ui.py

@@ -445,7 +445,9 @@ def format_cell(self, sound_file):
  def set_row_progress(self, number, progress):
  """Update the progress bar of a single row/file."""
  self.progress_column.set_visible(True)
- if self.model[number][2] == 1.0:
+ if abs(self.model[number][2] - progress * 100) < 1:
+ # only do the expensive gtk update when the delta progress
+ # is larger than 1%
  return
 
  self.model[number][2] = progress * 100.0