GTK progress optimizations and properly closing gst.pipeline #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezanzeb
changed the title
sezanzeb
changed the title
sezanzeb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI froze when converting too many files, because it updated each ones progress even though it remained the same for most files (0.0 or 1.0 when done). This was quite expensive. The change in
converter.pyis only for cosmetic reasons mostly as it didn't seem to have a large impact. Furthermore, pipelines are properly cleaned after conversion because at some point soundconverter crashed because of too many open files.I obviously should have done a stresstest earlier.
Also added an integration test for cancelling pipelines.