[bitnami/external-dns] ability to disable validation

There are some uses cases where the chart value validation should not be ran, this provides a way to disable it. fixes bitnami#19942 Signed-off-by: Jon Whitcraft <[email protected]>
jwhitcraft · Oct 10, 2023 · 3fc0ad5 · 3fc0ad5
1 parent d67f91a
commit 3fc0ad5
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/bitnami/external-dns/Chart.yaml b/bitnami/external-dns/Chart.yaml
@@ -28,4 +28,4 @@ maintainers:
 name: external-dns
 sources:
 - https://github.com/bitnami/charts/tree/main/bitnami/external-dns
-version: 6.26.4
+version: 6.26.5
diff --git a/bitnami/external-dns/README.md b/bitnami/external-dns/README.md
@@ -349,6 +349,7 @@ The command removes all the Kubernetes components associated with the chart and
 | `metrics.googlePodMonitor.namespace` | Namespace in which PodMonitoring created | `""` |
 | `metrics.googlePodMonitor.interval` | Interval at which metrics should be scraped by Google Managed Prometheus | `60s` |
 | `metrics.googlePodMonitor.endpoint` | The endpoint for Google Managed Prometheus scraping the metrics | `/metrics` |
+| `validation.enabled` | Enable chart validation | `true` |
 
 Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example,
 

diff --git a/bitnami/external-dns/templates/_helpers.tpl b/bitnami/external-dns/templates/_helpers.tpl
@@ -262,8 +262,9 @@ compartment: {{ .Values.oci.compartmentOCID }}
 {{ end }}
 
 {{/*
-Compile all warnings into a single message, and call fail.
+Compile all warnings into a single message, and call fail if the validation is enabled
 */}}
+{{- if .Values.validation.enabled -}}
 {{- define "external-dns.validateValues" -}}
 {{- $messages := list -}}
 {{- $messages := append $messages (include "external-dns.validateValues.provider" .) -}}
@@ -312,6 +313,9 @@ Compile all warnings into a single message, and call fail.
 {{- printf "\nVALUES VALIDATION:\n%s" $message | fail -}}
 {{- end -}}
 {{- end -}}
+{{- end -}}
+
+{{/*
 
 {{/*
 Validate values of External DNS:

diff --git a/bitnami/external-dns/values.yaml b/bitnami/external-dns/values.yaml
@@ -1110,3 +1110,11 @@ metrics:
  ## @param metrics.googlePodMonitor.endpoint The endpoint for Google Managed Prometheus scraping the metrics
  ##
  endpoint: /metrics
+
+
+## Chart Validation
+##
+validation:
+ ## @param validation.enabled Enable chart validation
+ ##
+ enabled: true