Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns] unable to disable validation on external-dns #19942

Closed
jwhitcraft opened this issue Oct 9, 2023 · 1 comment · Fixed by #20001
Closed

[bitnami/external-dns] unable to disable validation on external-dns #19942

jwhitcraft opened this issue Oct 9, 2023 · 1 comment · Fixed by #20001
Assignees
Labels
external-dns solved tech-issues The user has a technical issue about an application triage Triage is needed

Comments

@jwhitcraft
Copy link
Contributor

Name and Version

bitnami/external-dns:6.23.3

What architecture are you using?

amd64

What steps will reproduce the bug?

Using ArgoCD with the ArgoCD Vault Plugin, i'm unable to bypass the validation of the external-dns chart.

My use case is that we pass in the path to the secret location inside of Hashicorp Vault and then argocd-vault-plugin does a helm template --values values.yaml | argocd-vault-plugin generate - to substitute the path out of the yaml files into the correct values.

Which then ARGO will apply to the cluster.

https://github.com/argoproj-labs/argocd-vault-plugin

Are you using any custom parameters or values?

aws:
  region: <path:omnibus/data/cluster123/external-dns#awsRegion>
  assumeRoleArn: <path:omnibus/data/cluster123/external-dns#assumeRoleArn>
serviceAccount:
  name: <path:omnibus/data/cluster123/external-dns#serviceAccountName>
  annotations:
    eks.amazonaws.com/role-arn:  <path:omnibus/data/cluster123/external-dns#serviceAccountArn>
txtOwnerId: <path:omnibus/data/cluster123/external-dns#txtOwnerId>
domainFilters: [<path:omnibus/data/cluster123/external-dns#domainFilters>]
sources: [<path:omnibus/data/cluster123/external-dns#sources>]

What is the expected behavior?

Outputs the yaml with what was passed in, that way the argocd-vault-plugin can substitute out the values correctly.

What do you see instead?

Error: execution error at (external-dns/charts/external-dns/templates/NOTES.txt:11:3):
VALUES VALIDATION:\nexternal-dns: aws.assumeRoleArn
The AWS Role to assume must follow ARN format: arn:aws:iam::123455567:role/external-dns
Ref: https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html
Please set a valid ARN (--set aws.assumeRoleARN="xxxx")

Use --debug flag to render out invalid YAML

Additional information

It would be nice to have a flag that could be set to disable the validation, so more advance tools like this could be used.

Thanks,

@jwhitcraft jwhitcraft added the tech-issues The user has a technical issue about an application label Oct 9, 2023
@bitnami-bot bitnami-bot added this to Triage in Support Oct 9, 2023
@github-actions github-actions bot added the triage Triage is needed label Oct 9, 2023
@javsalgar javsalgar changed the title unable to disable validation on external-dns [bitnami/external-dns] unable to disable validation on external-dns Oct 10, 2023
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the suggestion. Would you like to submit a PR with a value for enabling/disabling the validation?

@github-actions github-actions bot moved this from Triage to Pending in Support Oct 10, 2023
jwhitcraft added a commit to jwhitcraft/charts-1 that referenced this issue Oct 10, 2023
There are some uses cases where the chart value validation should not
be ran, this provides a way to disable it.

fixes bitnami#19942

Signed-off-by: Jon Whitcraft <[email protected]>
jwhitcraft added a commit to jwhitcraft/charts-1 that referenced this issue Oct 10, 2023
There are some uses cases where the chart value validation should not
be ran, this provides a way to disable it.

fixes bitnami#19942

Signed-off-by: Jon Whitcraft <[email protected]>
jwhitcraft added a commit to jwhitcraft/charts-1 that referenced this issue Oct 11, 2023
There are some uses cases where the chart value validation should not
be ran, this provides a way to disable it.

fixes bitnami#19942

Signed-off-by: Jon Whitcraft <[email protected]>
@bitnami-bot bitnami-bot moved this from Pending to Solved in Support Oct 25, 2023
@github-actions github-actions bot removed this from Solved in Support Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns solved tech-issues The user has a technical issue about an application triage Triage is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants