Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the arch input, allow ARM64 as a synonym for aarch64 #110

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

DilumAluthge
Copy link
Member

To allow for compatibility with the ${{ runner.arch }} variable, which takes on the following values: X86, X64, ARM, or ARM64.

Fixes #107

@DilumAluthge DilumAluthge marked this pull request as ready for review June 20, 2022 11:23
@DilumAluthge DilumAluthge requested a review from a team as a code owner June 20, 2022 11:23
@DilumAluthge DilumAluthge force-pushed the dpa/arm64-synonym-for-aarch64 branch from cb55652 to cbb0715 Compare June 20, 2022 11:28
bors bot added a commit to JuliaRegistries/CompatHelper.jl that referenced this pull request Jun 20, 2022
430: GitHub Actions: for now, comment out the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge

We need julia-actions/setup-julia#108 and julia-actions/setup-julia#110 before we can uncomment this line.

Co-authored-by: Dilum Aluthge <[email protected]>
@SaschaMann
Copy link
Member

I like the addition, I'll merge it when CI is fixed.

@DilumAluthge DilumAluthge force-pushed the dpa/arm64-synonym-for-aarch64 branch from cbb0715 to 7050dbf Compare June 20, 2022 22:35
@DilumAluthge
Copy link
Member Author

@SaschaMann Is this one good to go now?

Copy link
Member

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is. Could you also open a PR that documents this option and #108, please?

Then I'll tag a release.

@SaschaMann SaschaMann merged commit 631e68d into master Jun 23, 2022
@SaschaMann SaschaMann deleted the dpa/arm64-synonym-for-aarch64 branch June 23, 2022 18:00
bors bot added a commit to JuliaRegistries/CompatHelper.jl that referenced this pull request Aug 15, 2022
434: GitHub Actions: uncomment the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge

Follow-up to #430.

julia-actions/setup-julia#108 and julia-actions/setup-julia#110 have been merged and are available in a release, so we can now uncomment this line.

Co-authored-by: Dilum Aluthge <[email protected]>
bors bot added a commit to JuliaRegistries/CompatHelper.jl that referenced this pull request Aug 15, 2022
434: GitHub Actions: uncomment the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge

Follow-up to #430.

julia-actions/setup-julia#108 and julia-actions/setup-julia#110 have been merged and are available in a release, so we can now uncomment this line.

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: in the arch input, support ARM64 as a synonym for aarch64
2 participants