Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the arch input, allow X64 and X86 as synonyms for x64 and x86, respectively #108

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

DilumAluthge
Copy link
Member

To allow for compatibility with the ${{ runner.arch }} variable, which takes on the following values: X86, X64, ARM, or ARM64.

@DilumAluthge DilumAluthge marked this pull request as ready for review June 20, 2022 11:23
@DilumAluthge DilumAluthge requested a review from a team as a code owner June 20, 2022 11:23
@DilumAluthge DilumAluthge force-pushed the dpa/arch-x64-x86-lowercase-capitalized branch from 2631a7a to 606e67c Compare June 20, 2022 11:24
bors bot added a commit to JuliaRegistries/CompatHelper.jl that referenced this pull request Jun 20, 2022
430: GitHub Actions: for now, comment out the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge

We need julia-actions/setup-julia#108 and julia-actions/setup-julia#110 before we can uncomment this line.

Co-authored-by: Dilum Aluthge <[email protected]>
@DilumAluthge DilumAluthge force-pushed the dpa/arch-x64-x86-lowercase-capitalized branch from 606e67c to 01844f3 Compare June 20, 2022 22:35
@SaschaMann SaschaMann enabled auto-merge (squash) June 23, 2022 18:00
@SaschaMann
Copy link
Member

@DilumAluthge needs a rebase due to the other PR but it can be automerged once that's done.

@DilumAluthge DilumAluthge force-pushed the dpa/arch-x64-x86-lowercase-capitalized branch from 01844f3 to f69022d Compare June 23, 2022 22:23
@SaschaMann SaschaMann merged commit 40ab89a into master Jun 23, 2022
@SaschaMann SaschaMann deleted the dpa/arch-x64-x86-lowercase-capitalized branch June 23, 2022 22:26
bors bot added a commit to JuliaRegistries/CompatHelper.jl that referenced this pull request Aug 15, 2022
434: GitHub Actions: uncomment the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge

Follow-up to #430.

julia-actions/setup-julia#108 and julia-actions/setup-julia#110 have been merged and are available in a release, so we can now uncomment this line.

Co-authored-by: Dilum Aluthge <[email protected]>
bors bot added a commit to JuliaRegistries/CompatHelper.jl that referenced this pull request Aug 15, 2022
434: GitHub Actions: uncomment the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge

Follow-up to #430.

julia-actions/setup-julia#108 and julia-actions/setup-julia#110 have been merged and are available in a release, so we can now uncomment this line.

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants