Fix missing clone overrides on derived aggregations(rapidsai#6898)

Fixes rapidsai#6891 Adds missing `clone()` overrides on aggregations that are derived but do not use `derived_aggregation`. Authors: - Jason Lowe <[email protected]> Approvers: - Mark Harris - MithunR - Alessandro Bellina URL: rapidsai#6898
jpurviance · Dec 4, 2020 · e22c3ae · e22c3ae
1 parent 1af9bc0
commit e22c3ae
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -189,6 +189,7 @@
 - PR #6869 Avoid dependency resolution failure in latest version of pip by explicitly specifying versions for dask and distributed
 - PR #6806 Force install of local conda artifacts
 - PR #6887 Fix typo and `0-d` numpy array handling in binary operation
+- PR #6898 Fix missing clone overrides on derived aggregations
 - PR #6899 Update JNI to new gather boundary check API
 
 

diff --git a/cpp/include/cudf/detail/aggregation/aggregation.hpp b/cpp/include/cudf/detail/aggregation/aggregation.hpp
@@ -61,6 +61,11 @@ struct min_aggregation final : aggregation {
       return {this->kind};
   }
   void finalize(aggregation_finalizer& finalizer) override { finalizer.visit(*this); }
+
+  std::unique_ptr<aggregation> clone() const override
+  {
+    return std::make_unique<min_aggregation>(*this);
+  }
 };
 
 /**
@@ -77,6 +82,11 @@ struct max_aggregation final : aggregation {
       return {this->kind};
   }
   void finalize(aggregation_finalizer& finalizer) override { finalizer.visit(*this); }
+
+  std::unique_ptr<aggregation> clone() const override
+  {
+    return std::make_unique<max_aggregation>(*this);
+  }
 };
 
 /**
@@ -173,6 +183,11 @@ struct mean_aggregation final : aggregation {
     return {aggregation::SUM, aggregation::COUNT_VALID};
   }
   void finalize(aggregation_finalizer& finalizer) override { finalizer.visit(*this); }
+
+  std::unique_ptr<aggregation> clone() const override
+  {
+    return std::make_unique<mean_aggregation>(*this);
+  }
 };
 
 /**