Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Columns dont work due to upstream MC issue #1

Open
jonbartels opened this issue May 4, 2022 · 8 comments
Open

Channel Columns dont work due to upstream MC issue #1

jonbartels opened this issue May 4, 2022 · 8 comments
Labels
good first issue Good for newcomers

Comments

@jonbartels
Copy link
Owner

nextgenhealthcare/connect#5171 breaks the channel columns.

Add a README and remove the annotation so the channel columns dont package.

@yimengZJl
Copy link

image
I'm not sure if that's okay

@jonbartels
Copy link
Owner Author

@yimengZJl I think you are right.

Try replacing the Engine Controller with a Channel Controller and see what happens.

@yimengZJl
Copy link

@jonbartels I tried. Channels couldn't load ,Same thing as this

@jonbartels
Copy link
Owner Author

Then try the fix I suggested at #5 (comment) .

@jonbartels
Copy link
Owner Author

nextgenhealthcare/connect#5171 has been fixed and a commit has been pushed to nextgenhealthcare/connect@ed40e34

To verify this fix I need to:

  • compile Mirth Connect from the development branch
  • Update my plugin for the dependencies for that version of Mirth
  • See if it works!

@jonbartels
Copy link
Owner Author

The channel list part of plugin does not work but I think this is a bug in the plugin.

The error from Mirth is not thrown any more. The channel list appears even if the plugin errors. The channel column simply doesnt display at all instead of throwing errors.

jonbartels pushed a commit that referenced this issue Feb 27, 2023
jonbartels added a commit that referenced this issue Dec 31, 2023
@jonbartels
Copy link
Owner Author

The ChannelColumnPlugin no longer errors, but it does not work cleanly either. There is a problem with the load order.

Copying some notes from Slack:

  [1 hour ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704038244590229)
From what I can tell com.jonbartels.mirthdashboard.ChannelListeningPortColumn#getColumnHeader is never called by [https://github.com/nextgenhealthcare/connect/blob/cf08dfbd133be8de931a4ca950a377b4[…]72921c/client/src/com/mirth/connect/client/ui/ChannelPanel.java](https://github.com/nextgenhealthcare/connect/blob/cf08dfbd133be8de931a4ca950a377b44d72921c/client/src/com/mirth/connect/client/ui/ChannelPanel.java#L3039)
I see it calling
In tableUpdate...
In getTableData...
So I know my plugin is loaded and the channel column class is loaded.
The Dashboard columns work but the Channel columns do not.  Any ideas before I run Mirth in Java debug mode and trace it down?
4 replies


jonb
  [17 minutes ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704040730205199?thread_ts=1704038244.590229&cid=C01QLL13HNU)
I think I found the problem. The channel panel code runs BEFORE the extensions are loaded by the client


jonb
  [8 minutes ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704041285428919?thread_ts=1704038244.590229&cid=C01QLL13HNU)
Repro steps:
Launch MCA with debugging (change the memory value in MCAL to 512m  -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005
BEFORE logging in, connect your IDE to the debugging port
Set breakpoints in ChannelPanel.java where it adds the headers
Set breakpoints in LoadedExtensions.java where it adds the channel column plugins
The LoadedExtensions code never returns any loaded plugins at this point
After you move past the breakpoints you will see the MCA status message "loading extensions"
The Channel Column plugin point can't ever work


jonb
  [6 minutes ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704041388016779?thread_ts=1704038244.590229&cid=C01QLL13HNU)
OMG. So then
Log out of MC (dont quit, just log out)
Log in again
Channel Column plugin works now


jonb
  [6 minutes ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704041410410729?thread_ts=1704038244.590229&cid=C01QLL13HNU)
I'm checking to see if the extension start is somehow called before the channel panel loads so I can pre-load the extension```

@jonbartels
Copy link
Owner Author

My plugin no longer errors but it does not work because of a new issue - nextgenhealthcare/connect#6046

@jonbartels jonbartels mentioned this issue Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants