Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Frame needs to load Extensions sooner #6046

Open
jonbartels opened this issue Dec 31, 2023 · 0 comments
Open

[BUG] Frame needs to load Extensions sooner #6046

jonbartels opened this issue Dec 31, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jonbartels
Copy link
Contributor

Describe the bug
Frame needs to load extensions when it says "Loading extensions..." and BEFORE initializing the Channel Panel.

We can see that the code is already aware of the need to load extensions before the Code Template panel. It needs to load extensions before the ChannelPanel for the same reason

        AuthorizationControllerFactory.getAuthorizationController().initialize();
        channelPanel = new ChannelPanel();
        channelPanel.retrieveGroups();
        channelPanel.retrieveDependencies();

        // Initialize all of the extensions now that the metadata has been retrieved
        // Make sure to initialize before the code template panel is created because it needs extensions
        LoadedExtensions.getInstance().initialize();

To Reproduce

  1. Implement a com.mirth.connect.plugins.ChannelColumnPlugin or grab the one from https://github.com/jonbartels/mirth-connect-dashboard-count
  2. Load the plugin
  3. Launch MC from the Launcher with console enabled
  4. View the Channels view; The custom headers will not be visible
  5. Log out of MCA (Log out, dont entirely close the client)
  6. Log back in
  7. You will see the custom headers in the Channels View

Expected behavior
A clear and concise description of what you expected to happen.

Actual behavior
Plugins expected to exist when ChannelPanel initializes are not available.

Environment (please complete the following information):

  • OS: MacOS
  • Java Distribution/Version: Java 17 as bundled with MCAL 1.4.1
  • Connect Version: 4.4.2

Workaround(s)
Probably not. There might be some stupid hack but I haven't found it.

Additional context
Discovered while working on #5171 and jonbartels/mirth-connect-dashboard-count#1

This may affect other extensions that affect the ChannelPanel but I have not tested this in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant