Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX heisenfailure in doc/memory.rst #1396

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Feb 17, 2023

As seen on various recent PRs.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 93.90% // Head: 93.93% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (58979ef) compared to base (1dcbf00).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
+ Coverage   93.90%   93.93%   +0.03%     
==========================================
  Files          52       52              
  Lines        7300     7341      +41     
==========================================
+ Hits         6855     6896      +41     
  Misses        445      445              
Impacted Files Coverage Δ
joblib/hashing.py 89.47% <0.00%> (-1.76%) ⬇️
joblib/test/test_parallel.py 96.93% <0.00%> (-0.12%) ⬇️
joblib/func_inspect.py 92.43% <0.00%> (+0.08%) ⬆️
joblib/memory.py 95.52% <0.00%> (+0.27%) ⬆️
joblib/_parallel_backends.py 93.38% <0.00%> (+0.36%) ⬆️
joblib/test/test_func_inspect.py 91.36% <0.00%> (+0.74%) ⬆️
joblib/_store_backends.py 91.58% <0.00%> (+0.81%) ⬆️
joblib/test/test_store_backends.py 94.54% <0.00%> (+3.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ogrisel
Copy link
Contributor Author

ogrisel commented Feb 17, 2023

PyPy is deadlocked after:

joblib/test/test_parallel.py::test_thread_bomb_mitigation[loky] PASSED   [ 96%]

this has been observed elsewhere and is not related to this PR.

@ogrisel ogrisel merged commit ef359b8 into joblib:master Feb 17, 2023
@ogrisel ogrisel deleted the fix-doctest-heisenfailure branch February 17, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant