-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/TST provide more informative traceback in case of a deadlock in tests #1379
Conversation
a5549db
to
805de8c
Compare
…f return_generator work
805de8c
to
eca5f2a
Compare
Codecov ReportBase: 94.01% // Head: 93.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
==========================================
- Coverage 94.01% 93.38% -0.64%
==========================================
Files 52 52
Lines 7300 7342 +42
==========================================
- Hits 6863 6856 -7
- Misses 437 486 +49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There are plenty of unrelated changes in this PR. I will open a new PR with only the required change to fix the flake8 problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the title to make it easy to understand the purpose of the PR without making any assumption about knowledge of concurrent PRs.
I think the new benchmark and the flake8 fix would have deserved independent PRs as those are unrelated and would have made it easier to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I haven't reviewed the new benchmark.
Could you please rename
benchmarks/bench_njobs_1.py
to benchmarks/bench_sequential_fast_tasks.py
?
@tomMoral can you please push your updated version of the bench script to this PR to be able to merge it? |
@ogrisel we will remove the bench from this PR and added in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
The memory.rst doctest failure is unrelated and is being addressed in #1396. The other failure (non silent resource tracker) has also been observed elsewhere so is probably unrelated as well. |
A set of changes proposed by @tomMoral in #588