Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update 'zh' to 'zh-CN' in lazygit Language Configuration #2842

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

try-to-fly
Copy link
Contributor

@try-to-fly try-to-fly commented Jul 29, 2023

  • PR Description
    This pull request corrects the language code in lazygit's documentation from 'zh' to 'zh-CN'. The previous 'zh' code was not working properly. This change improves the localization and usability for Chinese users. The change has been validated to ensure the 'zh-CN' option functions as expected.
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@Dragon1573
Copy link

Related bug

Unable to launch lazygit when setting gui.language to 'zh'. Switching it to auto DOES fix the problem and Simplified Chinese is selected as expected.

English en, Polish pl, Nederlands nl, Japanese ja, Korean ko works as usual.

23:03:54 ~/.c/lazygit 2ms $ js-yaml config.yml | jq '.gui.language'
"zh"
23:03:58 ~/.c/lazygit 123ms $ lazygit
2023/08/06 23:04:00 Language not found: zh
23:04:00 ~/.c/lazygit 213ms $                                                                                               ✘ 1
23:05:19 ~/.c/lazygit 1ms $ js-yaml config.yml | jq '.gui.language'
"auto"
23:05:22 ~/.c/lazygit 128ms $ lazygit
当前目录不在 git 仓库中。是否在此目录创建一个新的 git 仓库?(y/n): ^C⏎
23:05:28 ~/.c/lazygit 4.45s $                                                                                             ✘ 130

Copy link
Contributor

@Lutra-Fs Lutra-Fs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the language code 'zh-TW' should also be included.

docs/Config.md Outdated Show resolved Hide resolved
@jesseduffield
Copy link
Owner

Thanks for making this

@jesseduffield jesseduffield merged commit b2023f1 into jesseduffield:master Aug 21, 2023
11 of 12 checks passed
@try-to-fly try-to-fly deleted the patch-1 branch August 28, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants