Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazygit support #3121

Merged

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Aug 6, 2023

{
"name": "config.yml",
"description": "Lazy Git settings",
"fileMatch": ["**/.config/lazygit/config.yml", "**/.config/lazygit/config.yaml"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those file locations are only valid for Linux. On Mac and Windows, the paths are slightly different, see docs/Config.md. It seems that "**/lazygit/config.yml" is a pattern that should work for all platforms.

Also, I don't think we need .yaml in the pattern, as it is not supported by lazygit.

@hyperupcall hyperupcall merged commit 85f0376 into SchemaStore:master Aug 6, 2023
3 checks passed
@hyperupcall
Copy link
Collaborator

Thanks

@Lutra-Fs
Copy link

Lutra-Fs commented Aug 7, 2023

Hi there, I found that for Chinese translation, the setting value should be one of 'zh-CN' or 'zh-TW' instead of 'zh'. is there anyone who would like to make a fix? related to jesseduffield/lazygit#2842

@hyperupcall
Copy link
Collaborator

hyperupcall commented Aug 7, 2023

@Lutra-Fs Feel free to file an issue for that - I'll label it as Good First Issue and Help Wanted so it can be tracked and fixed faster

@EmilyGraceSeville7cf
Copy link
Contributor Author

I can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants