Support for SASL (revisiting PR #78) #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL changes have already come in, so I'm merging/reverting the SSL changes that we had added.
|
Back from vacation - thanks for sending this! Would you developers at Microsoft be interesting in having push permission to this repository? I think that makes a lot of sense and that'd help pushing new versions to npm faster. |
Additionally, updating SASL auth example to remove session option, and adding ssl option.
… changed the pattern to follow standard javascript importing) -Added an example for gremlin client with SASL. (username and pwd have to be set accordingly based on your gremlin server)
jbmusso
requested changes
Aug 29, 2017
src/GremlinClient.js
Outdated
| @@ -218,6 +226,21 @@ class GremlinClient extends EventEmitter { | |||
| return message; | |||
| }; | |||
|
|
|||
| buildChallengeResponse(requestId) { | |||
| const { processor, op, accept, language, aliases } = this.options; | |||
| var utf8 = require('utf8'); | |||
There was a problem hiding this comment.
Can you move this require() at the top as import utf8 from 'utf8' please? That should work ok with Babel.
jbmusso
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to perform SASL authentication on 407 challange responses.
This PR is revisiting changes for SASL support from: #78
FYI:
Earlier in May, I had created "gremlin-secure", a copy of the "gremlin" npm module which included the changes from this PR.
https://www.npmjs.com/package/gremlin-secure
Hoping that we can merge these changes back to the base repo, so that I can take down gremlin-secure, and point folks back to the original gremlin npm module :)