Support for SSL and SASL #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, this is definitely something we need to add. Thanks for sending this, I only see a couple minor issues with your PR so maybe we should start working from there. |
|
Hello, What's the current state of this PR? Did I understand correctly, that the library currently doesn't have any authentication support? |
jbmusso
pushed a commit
that referenced
this pull request
Aug 29, 2017
* SSL and SASL support. * Updating README to show how to use SASL Authentication. * Update, adding user and password to options list. Additionally, updating SASL auth example to remove session option, and adding ssl option. * Changed ordering of options. * -Moved utf8 importing to the top, to avoid reloading each time. (Also changed the pattern to follow standard javascript importing) -Added an example for gremlin client with SASL. (username and pwd have to be set accordingly based on your gremlin server)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for SSL and SASL
Sample usage:
The changes contain basic support for gremlin client to connect using SASL protocol to a Gremlin Server that supports authentication (Details on Gremlin SASL specification: http:https://tinkerpop.apache.org/docs/current/dev/provider/#_authentication).
The changes also contains support for SSL protocol (this is just about switching websockets ws:https:// to secure websockets wss:https:// based on an additional option supported by Gremlin.createClient() API)