Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quick ask improvement #2543

Merged
merged 2 commits into from
Mar 30, 2024
Merged

fix: quick ask improvement #2543

merged 2 commits into from
Mar 30, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Using different layout to prevent duplicate installing extension.
  • Fix an issue that can't drag Jan app in macos when drag on below half of top bar.
  • Debounce sending quick ask to main app.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Mar 29, 2024
@namchuai namchuai marked this pull request as ready for review March 29, 2024 18:11
@namchuai namchuai merged commit 96af5fb into dev Mar 30, 2024
6 checks passed
@namchuai namchuai deleted the fix/quick-ask-improvement branch March 30, 2024 01:59
@github-actions github-actions bot added this to the v0.4.11 milestone Mar 30, 2024
This was referenced Apr 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@urmauur urmauur Awaiting requested review from urmauur

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@namchuai @louis-jan @henryh0x1