Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: index.js.DELETE in conversational-extension causes Jan to fail #2480

Closed
dan-homebrew opened this issue Mar 24, 2024 · 4 comments
Closed
Assignees
Labels
P1: important Important feature / fix type: bug Something isn't working
Milestone

Comments

@dan-homebrew
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Steps to reproduce
Steps to reproduce the behavior:

  1. Auto-update on Windows Nightly
  2. Jan Window crashes with net::ERR_FILE_NOT_FOUND for extension:https://@janhq/conversational-extension/dist/index.js:1
  3. conversational-extension has index.js.DELETE.368138bae7ccd5dbfae4379cb93908f4
    image
    image

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your issue.

Environment details

  • Windows
  • Jan v0.4.9-341

Additional context
Add any other context or information that could be helpful in diagnosing the problem.

@dan-homebrew dan-homebrew added the type: bug Something isn't working label Mar 24, 2024
@Van-QA Van-QA added the P1: important Important feature / fix label Mar 25, 2024
@louis-jan
Copy link
Contributor

I encountered this issue last Saturday and have been investigating it since then. I still haven't been able to reproduce it, but I noticed that it occurred after I removed the .DELETE-xxxx extension. I will try to reproduce it.

@Propheticus
Copy link

All sorts of things broke and processes got stuck when I updated nightly 343 to 345 (preparing update ...). Had to do a clean uninstall > install.

@dan-homebrew dan-homebrew changed the title bug: Auto-update on Nightly causes Jan to crash bug: index.js.DELETE in conversational-extension causes Jan to fail Mar 29, 2024
@dan-homebrew
Copy link
Contributor Author

dan-homebrew commented Mar 29, 2024

This was fixed with a clean install of 0.4.9-350, including blowing away %APPDATA%

We should probably find a way to avoid having to make the user go into %APPDATA%, as a "reset" option.

We should also look into the underlying issue for the conversation extension beng deleted with index.js.DELETE - this seems like a temporal state that got persisted, or an upgrade that failed halfway?

@namchuai
Copy link
Contributor

namchuai commented Apr 1, 2024

I was able to reproduce this issue. Here's the steps:

  1. Using Jan version 0.4.9 (can take any build number)
  2. Go to %APPDATA%, edit settings.json. Set quick_ask to true
  3. Remove Jan data folder
  4. Observe that Jan can't open and yield issue that Dan mentioned above.

I fixed this issue with #2543 . @Van-QA , please help me to re-validate this issue on nightly build. Thank you very much 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants