Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: factory reset not remove jan data folder #2027

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix: factory reset not remove jan data folder #2027

merged 2 commits into from
Feb 15, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Factory reset does not remove jan data folder.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Feb 15, 2024
louis-jan
louis-jan approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 05eebfa into dev Feb 15, 2024
7 checks passed
@namchuai namchuai deleted the fix/factory-reset-on-windows branch February 15, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@namchuai @louis-jan