Upgrade Antd #1703
Labels
Comments
This was referenced Aug 20, 2023
|
Hi @yurishkuro, I want to work on this issue. Can you provide me more details. |
|
See #1636 for more discussion |
This was referenced Sep 4, 2023
4 tasks
yurishkuro
pushed a commit
that referenced
this issue
Oct 6, 2023
## Which problem is this PR solving? - part of: #1703 ## Description of the changes - This PR removes the ant-design compatibility package from the project while keeping each component UI and UX as it was previously. ## How was this change tested? - unit tests, and manually viewing each affected component. - Since, this PR affects the Search Form, Search Trace Form, and Trace Span Table View Filter Dropdowns, below is a screencast, showcasing the affected UIs [screen-capture (5).webm](https://github.com/jaegertracing/jaeger-ui/assets/94157520/4ca44e36-4bf9-4135-a951-817f07df7260) ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <[email protected]>
4 tasks
yurishkuro
pushed a commit
that referenced
this issue
Oct 8, 2023
…#1854) ## Which problem is this PR solving? - part of: #1703 ## Description of the changes - This PR removes the deprecated usages of some props from ant-design v4 components. - The `Menu` no longer supports children, and needs an items array to be passed. - `DropDown` no longer supports overlay, and needs an items array to be passed. Because of this change, we can no longer test the DropDown items but can verify the number of items. ## How was this change tested? - Manually, and unit tests. - Since this PR directly affects the TopNav, here's a demonstration of it working perfectly. [screen-capture (6).webm](https://github.com/jaegertracing/jaeger-ui/assets/94157520/eeb5284f-7b28-47f8-9b59-c3aee481dffa) ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <[email protected]>
This was referenced Oct 9, 2023
yurishkuro
pushed a commit
that referenced
this issue
Oct 9, 2023
…ePage (#1857) ## Which problem is this PR solving? - part of: #1703 ## Description of the changes - replace deprecated usage of Tabs component from SearchTracePage - The ant-design v4 introduces a new API `items` which increases the performance by deferring the In-Active components for the first load. - This is the reason we cannot test for the actual `FileLoader` component to be present, rather, we can [test for the Tab Key to be present](https://github.com/jaegertracing/jaeger-ui/pull/1857/files#diff-aed5cd35151c3219d94e8071c5fe875b963075a0c89df5f070c9b4c34dadf646R178). ## How was this change tested? - manually, and automated tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <[email protected]>
yurishkuro
pushed a commit
that referenced
this issue
Oct 9, 2023
…t-design v4 (#1855) ## Which problem is this PR solving? - part of: #1703 ## Description of the changes - This PR replaces the deprecated visible prop of ant-design v3 with open prop of ant-design v4 - These props are exactly the same, just the name differs. ## How was this change tested? - unit tests, and manually ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <[email protected]>
4 tasks
yurishkuro
added a commit
that referenced
this issue
Oct 11, 2023
…nts (#1859) ## Which problem is this PR solving? - part of: #1703 ## Description of the changes - This PR removes the deprecated usages from ant-design DropDown, Tooltip, and Tab components - The tab now needs an item array. Same with DropDown. - The `visible` is changed to `open` without any change in the internal working. ## How was this change tested? - manually, and unit tests ## What next? - There are still a few components left with deprecated usages. Those will covered in the upcoming PRs, to keep the code changes per PR small. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
4 tasks
yurishkuro
pushed a commit
that referenced
this issue
Oct 12, 2023
…sTable (#1864) ## Which problem is this PR solving? - part of: #1703 ## Description of the changes - This PR replaces the deprecated ant-design props from ReferenceButton and KeyValuesTable - The `colums.render` prop is no longer required to return children as JSX. Instead, it is by default. ## How was this change tested? - manually, and unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <[email protected]>
yurishkuro
pushed a commit
that referenced
this issue
Oct 24, 2023
## Which problem is this PR solving? - part of: #998 - fixes #1703 ## Description of the changes - The Size of this PR may look big, but there were no breaking changes except the following: - ant-design v5.0.0 no longer supports less variables. That means we have to use the `seedToken` and `aliasToken` in place of less variables. - With this change, we also needed to use the default styling of ant-design v4. For that, ant-design team provides a `compatible` package. - The notification.`close` and `warn` have been renamed `destory` and `warning` respectively. - PR: https://github.com/jaegertracing/jaeger-ui/pull/1839/files is reversed in this PR, because we are not really on @types/react v18. We are locked on v16 due to yarn resolution. Having v18 written in package.json was creating conflict with the installation of antd v5 [screen-capture (5).webm](https://github.com/jaegertracing/jaeger-ui/assets/94157520/550a79b7-b333-497b-9b73-70d0e6a1a748) ## How was this change tested? - Manually, and unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Creating a tracking issue since this is not a straightforward upgrade.
More discussion on #1636
Unfinished prior art #1261
The text was updated successfully, but these errors were encountered: