Antd icons from V3 to V4 complete #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
…ed with icons Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1702 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 241 241
Lines 7562 7562
Branches 1987 1987
=======================================
Hits 7261 7261
Misses 301 301
☔ View full report in Codecov by Sentry. |
|
Looks good to merge @yurishkuro |
...i/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap
Outdated
Show resolved
Hide resolved
bupd
commented
Aug 20, 2023
...i/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap
Outdated
Show resolved
Hide resolved
Signed-off-by: bupd <[email protected]>
|
@anshgoyalevil Updated the icons to look like the previous one |
yurishkuro
reviewed
Aug 20, 2023
| </Tooltip> | ||
| <Tooltip title={getTitle('Collapse All')} getPopupContainer={this.getContainer}> | ||
| <Icon type="double-right" onClick={onCollapseAll} className="TimelineCollapser--btn" /> | ||
| <DoubleRightOutlined onClick={onCollapseAll} className="TimelineCollapser--btn" /> |
There was a problem hiding this comment.
These changes look odd, do we have the same icons repeated twice? Can you add before/after screenshots?
There was a problem hiding this comment.
Before in V3
After in V4
For more Information Checkout:
- V4 Icons library
- V3 Icons library
The below shows the official change in the antdesign icons
There was a problem hiding this comment.
This wasn't my question, but it's ok, I found the answer - despite using the same icons, every 2nd copy of it is rotated 90 degrees, which makes them look different
bupd
commented
Aug 20, 2023
There was a problem hiding this comment.
@yurishkuro Rechecked all the icons visually and inspected them both are same
yurishkuro
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test