show outdated csi value #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and the color of the ring to grey
…ith the date of the last results
… the german date format to utils
…til function calls to the components
sburnicki
suggested changes
Aug 17, 2018
| def name = it.name | ||
| def lastDateOfResult = JobResult.createCriteria().list(max: 1) { | ||
| eq("jobGroupName", name) | ||
| order("id", "desc") |
There was a problem hiding this comment.
Better sort by date desc to make sure it's the last jobGroup
| [ | ||
| id : it.id, | ||
| name : it.name, | ||
| dateOfLastResults: lastDateOfResult[0].date.format("yyyy-MM-dd") |
There was a problem hiding this comment.
This may give you a NPE if lastDateOfResult is empty (no job result so far)
| @@ -1,7 +1,11 @@ | |||
| <div class="card"> | |||
| <div class="card" data-toggle="tooltip" | |||
| title="{{isCsiOutdated((pageCsiDate$ | async), lastDateOfResult) ? | |||
There was a problem hiding this comment.
Duplicate code. You could extract that as a method which provides the correct translation-key directly.
You could also put the tooltip in the osm-csi-value.
data-toggle is not needed afaik.
| } | ||
|
|
||
| private updateDescription() { | ||
| if (this.isBig && new Date().toISOString().substring(0, 10) > this.csiDate) { |
There was a problem hiding this comment.
is this date comparison working? It compares strings, doesn't it?
| it('should be described as is set', () =>{ | ||
| const description: string = "description"; | ||
| component.description = description; | ||
| it('should be described as "CSI" if the circle is not big', () => { |
There was a problem hiding this comment.
You can also add test cases for the new cases you defined.
sburnicki
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-The dashboard shows outdated csi values. Then the csi circle turns grey.
-If the csi value was not created today, the date of the csi value is shown in the circle instead of 'today'.
-If the csi value of a page is outdated, the circle also turns grey. A hint shows the calculation date of the csi page value.