Python build: copy files instead of creating link #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciovasquezbernal
requested review from
drzaeus77 and
goldshtn
as code owners
|
[buildbot, test this please] |
mauriciovasquezbernal
force-pushed
the
copy_files_python_build
branch
from
39e2240
to
11b095b
Compare
|
I'm not sure why tests were failing, I forced pushed to rerun them but I just realized that somebody has to ask the build bot to do it. |
|
@mauriciovasquezbernal No problem. Let me try to run again. |
|
[buildbot, test this please] |
After iovisor#1826 version.py is generated by cmake in order to have the __version__ define in the module. The previous approach of installing the python module created a link between the src and the "build" folder, hence the version.py was actually created in the scr folder, this caused some git noise. This comit solves that problem by copying files instead of creating a link, then the version.py file is only created in the "build" dir. Signed-off-by: Mauricio Vasquez B <[email protected]>
mauriciovasquezbernal
force-pushed
the
copy_files_python_build
branch
from
11b095b
to
0f4bc71
Compare
mauriciovasquezbernal
requested a review
from yonghong-song
as a code owner
|
Not sure what is going on with the pull request got stuck in testing stage. |
|
@yonghong-song I pushed a new modification, python tests were using the wrong source code. |
|
okay. |
|
[buildbot, test this please] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1964, more details in commit message.